trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #546: TRAFODION [109] Instrument Trafodion ...
Date Wed, 15 Jun 2016 16:06:04 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/546#discussion_r67192402
  
    --- Diff: core/sqf/sql/scripts/sqstart ---
    @@ -220,6 +220,31 @@ function SQCheckOrphanProcesses {
     
     }
     
    +function checkKerberos {
    +
    +   # Check to see if kerberos is enabled in Hadoop
    +   cat /etc/hadoop/conf/core-site.xml | while read a; do
    +     found=`echo $a | grep "hadoop.security.authentication" | wc -l`
    +     if [[ $found -eq 1 ]]; then
    +       read b
    +       enabled=`echo $b | grep kerberos | wc -l`
    --- End diff --
    
    I want to improve the check to see if Kerberos is enabled in general.  There is the issue
you mention above and in a customer environment, core-site may not be in the default location
(take install_local_hadoop for instance).   With a different solution, I hope to avoid scanning
core-site.   I did write up a JIRA to improve this (TRAFODION-2048).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message