trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #550: [TRAFODION-2074] Create index should ...
Date Mon, 20 Jun 2016 18:37:17 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/550#discussion_r67742676
  
    --- Diff: core/sql/exp/ExpHbaseInterface.h ---
    @@ -62,22 +62,6 @@ class ExHbaseAccessStats;
     
     Int64 getTransactionIDFromContext();
     
    -using namespace apache::thrift;
    -using namespace apache::thrift::protocol;
    -using namespace apache::thrift::transport;
    -
    -using namespace apache::hadoop::hbase::thrift;
    -
    -namespace {
    -
    -  typedef std::vector<std::string> StrVec;
    --- End diff --
    
    Yes. We can do this as a different PR because I suspect it would involve more code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message