trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #559: [TRAFODION-1988] Better Java exceptio...
Date Mon, 27 Jun 2016 17:26:50 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/559#discussion_r68619027
  
    --- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/src/main/java/org/trafodion/dtm/HBaseTxClient.java
---
    @@ -452,7 +436,13 @@ public short abortTransaction(final long transactionID) throws Exception
{
               Object commitDDLLock = new Object();
               synchronized(commitDDLLock)
               {
    -            commitDDLLock.wait();
    +             boolean loopBack = false;
    +             try {
    +                commitDDLLock.wait();
    +             } catch(InterruptedException ie) {
    +                 LOG.warn("Interrupting commitDDLLock.wait,  but retrying ", ie);
    +                 loopBack = true;
    +             } while (loopBack);
    --- End diff --
    
    This doesn't look right to me. Does "try" have a looping semantic when followed by "while"?
Or did you intend to code a do { } around the try/catch block? (I'm thinking that the "while
(loopBack);" does nothing if loopBack is false but loops infinitely if loopBack is true.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message