trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #564: [TRAFODION-1676]support better runtim...
Date Wed, 29 Jun 2016 15:32:07 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/564#discussion_r68969297
  
    --- Diff: core/sql/cli/Statement.cpp ---
    @@ -2102,6 +2102,30 @@ Statement * Statement::getCurrentOfCursorStatement(char * cursorName)
     
     }
     
    +//////////////////////////////////////////////////////////////////
    +////
    +//// A helper function to show buffer in HEX
    +////
    +//// ///////////////////////////////////////////////////////////////
    +
    +static char *stringToHex(char * out, Int32 outLen, char * in, Int32 inLen)
    --- End diff --
    
    Could this function please be declared in some place like exp/ExpError.h (with an implementation
in ExpError.cpp)? I see this function implemented twice in this PR and something similar in
a previous PR. I think this is not advisable according to our coding guidelines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message