trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #564: [TRAFODION-1676]support better runtim...
Date Wed, 29 Jun 2016 15:55:10 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/564#discussion_r68973952
  
    --- Diff: core/sql/cli/Statement.cpp ---
    @@ -2102,6 +2102,30 @@ Statement * Statement::getCurrentOfCursorStatement(char * cursorName)
     
     }
     
    +//////////////////////////////////////////////////////////////////
    +////
    +//// A helper function to show buffer in HEX
    +////
    +//// ///////////////////////////////////////////////////////////////
    +
    +static char *stringToHex(char * out, Int32 outLen, char * in, Int32 inLen)
    --- End diff --
    
    thanks @sureshsubbiah , I was not able to find a common header file. ExpError.h is a good
one. I will move this function into there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message