trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #564: [TRAFODION-1676]support better runtim...
Date Wed, 29 Jun 2016 15:58:32 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/564#discussion_r68974494
  
    --- Diff: core/sql/exp/exp_conv.cpp ---
    @@ -1445,6 +1445,10 @@ ex_expr::exp_return_type convUnicodeToDatetime(char *target,
        }
     
        ExRaiseSqlError(heap, diagsArea, EXE_CONVERT_DATETIME_ERROR);
    +   char hexstr[256];
    +   if(*diagsArea)
    --- End diff --
    
    In some code paths, both heap and **diagsArea can be NULL, but *diagsArea is not NULL,
that is the reason I add a safety checking 
    if(*diagsArea), but yes, *diagsArea may also be possible to be NULL (although by design
that is not possible IMHO). The proposed change is a very good one. i will make the change.
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message