trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From blfritch-esgyn <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #517: Fix problems with use of HBase row co...
Date Thu, 02 Jun 2016 20:37:36 GMT
GitHub user blfritch-esgyn opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/517

    Fix problems with use of HBase row count estimate

    The CQD ESTIMATE_HBASE_ROW_COUNT is no longer used anywhere but in
    Update Stats, which also uses USTAT_ESTIMATE_HBASE_ROW_COUNT. Both
    have to be set before the row count is estimated, and the flawed
    logic used in this decision sometimes results in estimation being
    performed twice. The former CQD has been removed, the latter set
    to ON by default, and the decision logic has been cleaned up.
    Also, the estimation is avoided if it is known that it will not
    be used (e.g., if sampling is not being used).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/blfritch-esgyn/incubator-trafodion TRAFODION-2019

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #517
    
----
commit 9a6be3e04e1f9e463530cb954d49582ac9b1fab9
Author: Barry Fritchman <blfritch@edev08.esgyn.local>
Date:   2016-06-02T20:22:48Z

    Fix problems with use of HBase row count estimate
    
    The CQD ESTIMATE_HBASE_ROW_COUNT is no longer used anywhere but in
    Update Stats, which also uses USTAT_ESTIMATE_HBASE_ROW_COUNT. Both
    have to be set before the row count is estimated, and the flawed
    logic used in this decision sometimes results in estimation being
    performed twice. The former CQD has been removed, the latter set
    to ON by default, and the decision logic has been cleaned up.
    Also, the estimation is avoided if it is known that it will not
    be used (e.g., if sampling is not being used).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message