trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #564: [TRAFODION-1676]support better runtim...
Date Wed, 29 Jun 2016 12:51:10 GMT
GitHub user traflm opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/564

    [TRAFODION-1676]support better runtime error message when a SQL funct…

    …ion meet fital error
    
    During normal query execution, the error message of many functions doesn't contain any
clue about what data cause the error, making it rather difficult to find the offending source.
Especially difficult when doing bulkload where millions of rows are about to be loaded, if
there are some bad value, it is extremely hard to find them.
    
    This PR enhance error messages for these SQL Errors:
    EXE_CONVERTTIMESTAMP_ERROR	= 8405,
    EXE_JULIANTIMESTAMP_ERROR	= 8407,
    EXE_CONVERT_STRING_ERROR	= 8413
    EXE_CONVERT_DATETIME_ERROR	= 8415,
    
    By displaying the offending source data content, for CONVERT_STRING_ERROR, because it
always contains multi-byte character, so display the data in HEX mode.
    
    This was minor issue, but become high recently because it is really very hard to fix source
data if error msg cannot tell the user enough info. With this change, the user can search
for bad value in source more easier.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/traflm/incubator-trafodion TRAFODION-2046-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/564.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #564
    
----
commit 5b8eba5598f8e45339a1ba649cd2214117ed7381
Author: Liu Ming <ovis_poly@sina.com>
Date:   2016-06-29T12:47:38Z

    [TRAFODION-1676]support better runtime error message when a SQL function meet fital error

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message