trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #590: JIRA TRAFODION-2099 Add support for b...
Date Mon, 11 Jul 2016 20:43:08 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/590#discussion_r70332990
  
    --- Diff: core/sql/common/MiscType.h ---
    @@ -106,25 +118,63 @@ class SQLBoolean : public NAType
     				       CollHeap* h,
     				       UInt32 *flags = NULL) const;
       
    +  // ---------------- Methods not inherited from NAType ----------------
    +
    +  NABoolean canBeSQLUnknown() const { return sqlUnknownFlag_;}
    +
    +  private:
    +  NABoolean sqlUnknownFlag_;
    --- End diff --
    
    So, the reason SQLBooleanRelat is a different class than SQLBooleanNative is that SQLBooleanRelat
has to model the three-valued logic of SQL predicates (that is, true/false/unknown), while
SQLBooleanNative has to model a possibly nullable two-value logic (true/false/null).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message