trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #593: [TRAFODION-2109] Load with log error ...
Date Fri, 15 Jul 2016 17:14:21 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/593#discussion_r71007538
  
    --- Diff: core/sql/executor/ExHbaseAccess.cpp ---
    @@ -2967,22 +2968,28 @@ void ExHbaseAccessTcb::handleException(NAHeap *heap,
                                         ComCondition *errorCond,
                                         ExpHbaseInterface * ehi,
                                         NABoolean & LoggingFileCreated,
    -                                    char *loggingFileName)
    +                                    char *loggingFileName,
    +                                    ComDiagsArea **loggingErrorDiags)
     {
       Lng32 errorMsgLen = 0;
       charBuf *cBuf = NULL;
       char *errorMsg;
       Lng32 retcode;
     
    +  if (*loggingErrorDiags != NULL)
    --- End diff --
    
    Not quite sure I understand this logic. If a ComDiagsArea object has already been allocated,
does that mean we have already reported the exception somewhere else? Or perhaps this is not
the first exception and we simply don't want to log more than one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message