trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request #644: Trafodion 1788
Date Mon, 08 Aug 2016 21:04:36 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/sqlcomp/PrivMgrMD.h ---
    @@ -187,6 +202,25 @@ class ObjectUsage
       PrivMgrDesc originalPrivs;
       PrivMgrDesc updatedPrivs;
    +  void copyColumnReferences(const std::vector<ColumnReference *> *refsToCopy)
    +  {
    +    if (refsToCopy == NULL)
    --- End diff --
    Might there be an old value in columnReferences? Do we need to do an NABASICDELETE (or
a delete) on it before assigning a new object pointer to it?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message