trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #647: [TRAFODION-2146] Use of CQD to set sc...
Date Mon, 08 Aug 2016 22:50:08 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/647#discussion_r73970577
  
    --- Diff: core/sql/generator/GenResources.cpp ---
    @@ -83,12 +62,13 @@ static ExScratchDiskDrive * genScratchDriveList(const NAString &def,
       // end temporary
     
       const char *str = def.data();
    -  if (!*str)
    +  if (!str || str=="")
    --- End diff --
    
    Doesn't "str == """ mean, compare the address str to the address of the constant, empty
string? If so, then this test is always false. I suspect what you intended to test is, "*str
== '\0'"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message