trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #651: Trafodion 2140
Date Wed, 10 Aug 2016 13:33:38 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/651#discussion_r74244160
  
    --- Diff: core/sql/optimizer/RelSample.cpp ---
    @@ -925,7 +925,6 @@ RelExpr *RelSample::bindNode(BindWA *bindWA)
       RelExpr* myChild = child(0);
       if (myChild->getOperatorType() == REL_SCAN &&
           (static_cast<Scan*>(myChild))->isHbaseTable() &&
    -      myChild->selectionPred().entries() == 0 &&
    --- End diff --
    
    I would have assumed that we still need this check for a query with a sample clause and
a predicate ? Not for update stats, but for some other SELECT statement with SAMPLE. Simple
predicates can be pushed down only for regular format rows, for aligned format rows predicate
evaluation will be in Trafodion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message