trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request #651: Trafodion 2140
Date Wed, 10 Aug 2016 21:15:42 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/ustat/hs_cli.cpp ---
    @@ -524,12 +531,14 @@ Lng32 HSSample::create(NAString& tblName, NABoolean unpartitioned,
NABoolean isP
                tableOptions = " WITH PARTITIONS";
             // If a transaction is running, the table needs to be created as audited.
             // Otherwise, create table as non-audited.
    +        /* TEMPTEMP. Dave need to validate this change.
             if (TM->InTransaction())
               tableOptions += " ATTRIBUTE AUDIT";
               tableOptions += " ATTRIBUTE NO AUDIT";
             tableOptions += getTempTablePartitionInfo(unpartitioned, isPersSample);
    +        */
    --- End diff --
    That's fine. Actually, the reason that this code had to be commented out is due to a change
I made in Given your experiment, the
change looks correct to me now.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message