trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #654: Various fixes, details listed below
Date Thu, 11 Aug 2016 21:18:33 GMT
GitHub user anoopsharma00 opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/654

    Various fixes, details listed below

    --error message returned during string to float conversion error was not
    correct. That has been fixed.
    
    -- ordering was not getting set correctly during key encoding.
    
    -- stored descriptor was not getting stored correctly if
    the generated length was exactly 10000 bytes (max length of TEXT.text col).
    
    -- time part of european date format is now handled correctly
    by using '.' as delimiter instead of ':'
    
    -- repeat function was crashing if specified maxlength was not sufficient
    to hold the result. It now returns an overflow error.
    
    -- tinyint key columns were not handling the case of overflow/underflow
    when used in a key predicate. That has been fixed.
    
    -- Numeric datatype with precision less than 3 is now created as tinyint
    and handled in expressions.
    
    -- some non-tinyint datatypes(float, decimal) were not being handled
    correctly when converted to tinyint. That has been fixed.
    
    -- some more pcode instructions involving tinyint range check and
    conversions have been added.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anoopsharma00/incubator-trafodion ansharma_trafixes_br

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/654.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #654
    
----
commit 52234cd846f4ba7bda76d95a36173c740cea224c
Author: Anoop Sharma <anoop.sharma@esgyn.com>
Date:   2016-08-11T21:16:52Z

    Various fixes, details listed below
    
    --error message returned during string to float conversion error was not
    correct. That has been fixed.
    
    -- ordering was not getting set correctly during key encoding.
    
    -- stored descriptor was not getting stored correctly if
    the generated length was exactly 10000 bytes (max length of TEXT.text col).
    
    -- time part of european date format is now handled correctly
    by using '.' as delimiter instead of ':'
    
    -- repeat function was crashing if specified maxlength was not sufficient
    to hold the result. It now returns an overflow error.
    
    -- tinyint key columns were not handling the case of overflow/underflow
    when used in a key predicate. That has been fixed.
    
    -- Numeric datatype with precision less than 3 is now created as tinyint
    and handled in expressions.
    
    -- some non-tinyint datatypes(float, decimal) were not being handled
    correctly when converted to tinyint. That has been fixed.
    
    -- some more pcode instructions involving tinyint range check and
    conversions have been added.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message