trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From svarnau <>
Subject [GitHub] incubator-trafodion pull request #704: [TRAFODION-1794]: Log authentication ...
Date Wed, 14 Sep 2016 17:46:10 GMT
Github user svarnau commented on a diff in the pull request:
    --- Diff: core/dbsecurity/auth/Makefile ---
    @@ -70,10 +67,11 @@ INCLUDES	= -I. -I./inc -I ../shared/inc \
     	        -I $(MY_SQROOT)/../sql/export \
     	        -I $(MY_SQROOT)/../sql/porting_layer \
     	        -I $(MY_SQROOT)/export/include \
    +	        -I $(MY_SQROOT)/commonLogger \
     	        -I ../../sql/common
    -LINK_OPTIONS	= -L$(LIBEXPDIR) -lldap -lssl -llber
    +LINK_OPTIONS	= -L$(LIBEXPDIR) -lldap -lssl -llber -llog4cxx
     COMMON_LIBS =  -ltdm_sqlcli -larkcmp_dll  
    --- End diff --
    Makefile changes look fine. You might want to remove this COMMON_LIBS line since it is
not actually being used.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message