trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <>
Subject [GitHub] incubator-trafodion pull request #704: [TRAFODION-1794]: Log authentication ...
Date Tue, 20 Sep 2016 15:18:27 GMT
Github user robertamarton commented on a diff in the pull request:
    --- Diff: core/dbsecurity/auth/inc/authEvents.h ---
    @@ -0,0 +1,89 @@
    +// @@@ START COPYRIGHT @@@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +// @@@ END COPYRIGHT @@@
    +#define INCLUDE_AUTHEVENT_H  1
    +#include "common/evl_sqlog_eventnum.h"
    +#include "CommonLogger.h"
    +#include <string>
    +#include <vector>
    +// From a web search, the log message max length is a bit over 8000 bytes.
    +// For DBSecurity don't believe any messages will be more than 1M
    +#define MAX_EVENT_MSG_SIZE 1024
    +// The ported code had the caller sending in the filename and line number
    +// for certain events.  This has not been implemented at this time.
    +struct AuthEvent
    --- End diff --
    Changed it to a class

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message