trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #713: Second set of changes for JIRA [TRAFO...
Date Wed, 21 Sep 2016 20:35:57 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/713#discussion_r79925711
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/SsccRegionEndpoint.java.tmpl
---
    @@ -2594,7 +2994,76 @@ CoprocessorService, Coprocessor {
         SsccCheckAndPutRegionTxResponse checkAndPutRegionTxResponse = checkAndPutRegionTxResponseBuilder.build();
     
         done.run(checkAndPutRegionTxResponse);
    -    */
    +  }
    +
    +  /**
    +   * Processes a checkAndDelete operation using a region transaction
    +   * @param long transactionId
    +   * @param byte[] row
    +   * @param byte[] family
    +   * @param byte[] qualifier
    +   * @param byte[] value
    +   * @param Delete delete
    +   * @param boolean autoCommit
    +   * @return boolean
    +   * @throws IOException
    +   */
    +  public boolean checkAndDeleteRegionTx(long tid, long startId,
    +                                byte[] row, byte[] family,
    +                                byte[] qualifier, byte[] value,
    +                                Delete delete, boolean autoCommit) throws IOException
{
    +
    +    if (LOG.isTraceEnabled()) LOG.trace("Enter checkAndDeleteRegionTx, tid: " + tid);
    +    SsccTransactionState state = this.beginTransIfNotExist(tid, startId, true); // This
is a regionTX
    +    boolean result = false;
    +    byte[] rsValue = null;
    +
    +    Get get = new Get(row);
    +    get.addColumn(family, qualifier);
    +
    +    Result rs = this.get(tid, startId, get);
    +
    +    boolean valueIsNull = value == null ||
    --- End diff --
    
    I assume this is an HBase-ism. I wonder how zero-length varchar strings are represented?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message