trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request #714: [TRAFODION-1988] Better java exceptio...
Date Wed, 21 Sep 2016 20:47:09 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/javaobjectinterfacetm.cpp ---
    @@ -421,21 +422,32 @@ bool  JavaObjectInterfaceTM::getExceptionDetails(JNIEnv *jenv)
            _tlp_error_msg = error_msg;
            return false;
    +   error_msg = new std::string("");
    +   appendExceptionMessages(jenv, a_exception, error_msg);
    +   *error_msg += "\n";
    +   _tlp_error_msg = error_msg;
    +   return true;
    +void JavaObjectInterfaceTM::appendExceptionMessages(JNIEnv *jenv, jthrowable a_exception,
std::string *error_msg)
    --- End diff --
    If we don't expect error_msg to be null, it might be better to code this as a reference
parameter rather than a pointer.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message