trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #716: [TRAFDODION-2170] create table with t...
Date Wed, 21 Sep 2016 20:56:07 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/716#discussion_r79930410
  
    --- Diff: core/sqf/src/tm/tmddlrequests.cpp ---
    @@ -40,14 +40,24 @@ JNIEXPORT jint JNICALL Java_org_apache_hadoop_hbase_client_transactional_RMInter
        char la_tbldesc[TM_MAX_DDLREQUEST_STRING];
        char la_tblname[TM_MAX_DDLREQUEST_STRING];
        char* str_key;
    -   str_key = new char[TM_MAX_DDLREQUEST_STRING];
        char** la_keys;
        la_keys = new char *[TM_MAX_DDLREQUEST_STRING];
        int lv_error = FEOK;
     
    +   if( pv_keyLength > TM_MAX_DDLREQUEST_STRING)
    +   {
    +     cout << "Table key length is larger than max allowed " << pv_keyLength
<< endl;
    --- End diff --
    
    A native English speaker will see "Table key length is larger than max allowed 5123" and
think that 5123 is the max, instead of the actual key length value. It might be a bit clearer
if it were "Table key length 5123 is larger than max allowed".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message