trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #714: [TRAFODION-1988] Better java exceptio...
Date Thu, 22 Sep 2016 00:39:47 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/714#discussion_r79961711
  
    --- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/javaobjectinterfacetm.cpp ---
    @@ -421,21 +422,32 @@ bool  JavaObjectInterfaceTM::getExceptionDetails(JNIEnv *jenv)
            _tlp_error_msg = error_msg;
            return false;
        }
    +   error_msg = new std::string("");
    +   appendExceptionMessages(jenv, a_exception, error_msg);
    +   *error_msg += "\n";
    +   _tlp_error_msg = error_msg;
    +   return true;
    +}
    +
    +void JavaObjectInterfaceTM::appendExceptionMessages(JNIEnv *jenv, jthrowable a_exception,
std::string *error_msg)
    --- End diff --
    
    @Dave fixed as per your comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message