trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sbroeder <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #713: Second set of changes for JIRA [TRAFO...
Date Thu, 22 Sep 2016 01:40:30 GMT
Github user sbroeder commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/713#discussion_r79966026
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/SsccTransactionalTable.java
---
    @@ -274,6 +278,48 @@ public SsccDeleteTransactionalResponse call(SsccRegionService instance)
throws I
                   throw new IOException(resultArray[0].getException());
               }
     
    +    public void deleteRegionTx(final long tid, final Delete delete, final boolean autoCommit)
throws IOException {
    +      SingleVersionDeleteNotSupported.validateDelete(delete);
    +      final String regionName = super.getRegionLocation(delete.getRow()).getRegionInfo().getRegionNameAsString();
    +         Batch.Call<SsccRegionService, SsccDeleteRegionTxResponse> callable =
    +                new Batch.Call<SsccRegionService, SsccDeleteRegionTxResponse>()
{
    +            ServerRpcController controller = new ServerRpcController();
    +            BlockingRpcCallback<SsccDeleteRegionTxResponse> rpcCallback =
    +            new BlockingRpcCallback<SsccDeleteRegionTxResponse>();
    +
    +            public SsccDeleteRegionTxResponse call(SsccRegionService instance) throws
IOException {
    --- End diff --
    
    Good comment.  I don't think @Override is needed on any of the region operations since
none are present in the super class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message