trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #705: [TRAFODION-2220] Change handling of m...
Date Wed, 14 Sep 2016 18:05:22 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/705

    [TRAFODION-2220] Change handling of manual persistent sample tables

    Changed the handling of persistent sample tables (that is, those created by UPDATE STATISTICS
... CREATE SAMPLE) to be the same as those created using the PERSISTENT keyword (that is,
those created by UPDATE STATISTICS ... SAMPLE RANDOM PERSISTENT). This is a simpler model;
now these tables are used interchangeably.
    
    As before, we still limit a table to having at most one persistent sample table.
    
    Contrary to before, the behavior when creating a persistent sample table (via either syntax)
when one already exists has been changed. Before we would silently drop the earlier table;
now the UPDATE STATISTICS statement will fail with error 9251. This is better behavior, because
it prevents a user from accidentally destroying an existing persistent sample. The user has
to explicitly remove it instead.
    
    So, in the test script for this JIRA, the last UPDATE STATISTICS command will now fail
with error 9251 (rather than the mysterious error 8102).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2220

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #705
    
----
commit b3e01ba3ea9ca964ef4086b516b89eb2bf2d43cb
Author: Dave Birdsall <dbirdsall@apache.org>
Date:   2016-09-14T17:57:36Z

    [TRAFODION-2220] Change handling of manual persistent sample tables

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message