trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #716: [TRAFDODION-2170] create table with t...
Date Tue, 20 Sep 2016 17:07:05 GMT
GitHub user traflm opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/716

    [TRAFDODION-2170] create table with too long key causing core dump

    If the create table DDL have key length (total len of all PK field) is greater than 2048,
the buffer created in the function will be overrun, and cause memory corruption and core dump.
    Adding a length check. The error message will be handled by TRAFODION-2231.
    
    Also fix memory leak issues pointed by Hans in previous PR review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/traflm/incubator-trafodion TRAFODION-2170-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #716
    
----
commit 4b21c915d443e31b66316900b24bd8176d5baa60
Author: Liu Ming <ovis_poly@sina.com>
Date:   2016-09-20T17:00:12Z

    [TRAFDODION-2170] create table with too long key causing core dump

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message