trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #739: [TRAFODION-2159] Outputs not promoted...
Date Mon, 03 Oct 2016 21:14:08 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/739#discussion_r81634915
  
    --- Diff: core/sql/optimizer/NormRelExpr.cpp ---
    @@ -3958,9 +3963,12 @@ GroupByAgg* Join::moveUpGroupByTransformation(const GroupByAgg*
topGrby,
       GroupByAgg *moveUpGrby;
       ValueIdSet emptySet ;
       GroupByAgg *movedUpGrbyTail = (GroupByAgg*) topGrby;
    +  GroupByAgg *subQGrby = NULL;
    --- End diff --
    
    Comment on existing line 3965: This is bad, we take a const GroupByAgg * as an argument,
then we cast away that const-ness and modify the child of the node later. The topGrby argument
cannot be a const.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message