trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #737: [TRAFODION-2247] upsert on altered al...
Date Tue, 04 Oct 2016 22:41:27 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/737#discussion_r81869515
  
    --- Diff: core/sql/generator/GenRelUpdate.cpp ---
    @@ -539,7 +415,9 @@ static short genHbaseUpdOrInsertExpr(
          updateRowLen,      // (OUT) Destination tuple length
          updateExpr,  // (OUT) Generated expression
          updateTupleDesc, // (OUT) Tuple descriptor for destination tuple
    -     ExpTupleDesc::LONG_FORMAT);
    +     ExpTupleDesc::LONG_FORMAT,
    +     NULL, NULL, 0, NULL, NULL,
    --- End diff --
    
    Should this be NULL, NULL, 0, NULL, FALSE? (the last of these is an NABoolean, disableConstFolding).
Though the code still works since NULL would map to FALSE.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message