trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #772: Do not merge! Preview of TRAFODION-21...
Date Wed, 26 Oct 2016 22:57:04 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/772#discussion_r85221360
  
    --- Diff: core/sql/arkcmp/CmpStatement.cpp ---
    @@ -1688,3 +1690,26 @@ void CmpStatement::setTMUDFRefusedRequirements(const char *details)
     
       detailsOnRefusedRequirements_->insert(new(heap_) NAString(details, heap_));
     }
    +
    +void CmpStatement::addCSEInfo(CSEInfo *info)
    +{
    +  if (cses_ == NULL)
    +    cses_ = new(CmpCommon::statementHeap())
    +      LIST(CSEInfo *)(CmpCommon::statementHeap());
    +
    +  info->setCSEId(cses_->entries());
    +  cses_->insert(info);
    +}
    +
    +CSEInfo * CmpStatement::getCSEInfo(const char *cseName)
    +{
    +  if (cses_)
    +    for (CollIndex i=0; i<cses_->entries(); i++)
    +      {
    +        if ((*cses_)[i]->getName() == cseName)
    --- End diff --
    
    Can there be more than one WITH clause in a statement with the same name? For example,
could we use a WITH inside an EXISTS subquery?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message