trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #772: Do not merge! Preview of TRAFODION-21...
Date Thu, 27 Oct 2016 01:01:34 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/772#discussion_r85250377
  
    --- Diff: core/sql/comexe/ComTdbExeUtil.cpp ---
    @@ -1302,6 +1302,7 @@ void ComTdbExeUtilFastDelete::displayContents(Space * space,
     ComTdbExeUtilHiveTruncate::ComTdbExeUtilHiveTruncate(
          char * tableName,
          ULng32 tableNameLen,
    +     char * hiveTableName,
    --- End diff --
    
    Could you explain what you mean by "bound"? This is just added here to include the table
name in the TDB, so we have access to it at runtime. Maybe you are saying that we could use
a host variable for the name instead? Yes, that would be doable, but it's not currently done
for the truncate command and it probably wouldn't be easy for most other commands such as
load, etc. In this particular case, I'm just adding the Hive table name, the SQL statement
uses the ANSI SQL name, e.g. HIVE.HIVE.T, and that name is also stored in the TDB.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message