trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #772: Do not merge! Preview of TRAFODION-21...
Date Thu, 27 Oct 2016 01:12:09 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/772#discussion_r85251226
  
    --- Diff: core/sql/generator/GenPreCode.cpp ---
    @@ -10715,7 +10808,10 @@ RelExpr * PhysicalFastExtract::preCodeGen (Generator * generator,
       if (nodeIsPreCodeGenned())
         return this;
     
    -  generator->setIsFastExtract(TRUE);  
    +  if (getIsMainQueryOperator())
    +    generator->setIsFastExtract(TRUE);
    +  else
    +    generator->setContainsFastExtract(TRUE);
    --- End diff --
    
    The "is" and the "contains" refer to the entire statement. The Generator::isFastExtract()
method is used to determine the overall statement type. What I needed was a flag indicating
that there is some fast extract somewhere in the statement (e.g. the one used to populate
a temp table), while the overall statement type is something else, like a select. I added
a comment to make that more clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message