trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #772: Do not merge! Preview of TRAFODION-21...
Date Thu, 27 Oct 2016 01:15:03 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/772#discussion_r85251454
  
    --- Diff: core/sql/generator/GenRelScan.cpp ---
    @@ -1119,7 +1124,8 @@ short FileScan::codeGenForHive(Generator * generator)
       if (expirationTimestamp > 0)
         expirationTimestamp += 1000000 *
           (Int64) CmpCommon::getDefaultLong(HIVE_METADATA_REFRESH_INTERVAL);
    -  generator->setPlanExpirationTimestamp(expirationTimestamp);
    +  if (!getCommonSubExpr())
    +    generator->setPlanExpirationTimestamp(expirationTimestamp);
    --- End diff --
    
    The way I understand it, this controls how often we validate the timestamps of Hive tables
(directories where Hive files reside). This is used to make concurrent changes to Hive tables
visible immediately at runtime. I think Anoop used the same CQD we have for the metadata for
the runtime check, where people can defer this check for a while. The default for this is
0, which means to check every time we execute a statement on a Hive table.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message