trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #772: Do not merge! Preview of TRAFODION-21...
Date Thu, 27 Oct 2016 15:55:53 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/772#discussion_r85368771
  
    --- Diff: core/sql/comexe/ComTdbExeUtil.cpp ---
    @@ -1302,6 +1302,7 @@ void ComTdbExeUtilFastDelete::displayContents(Space * space,
     ComTdbExeUtilHiveTruncate::ComTdbExeUtilHiveTruncate(
          char * tableName,
          ULng32 tableNameLen,
    +     char * hiveTableName,
    --- End diff --
    
    By "bound at compile time" I mean the Hive table name is chosen at compile time rather
than execution time. If the table name were chosen at execution time, we would put it in the
TCB (or some other executor data structure) but not the TDB. If we chose the name at execution
time, then the query plan could be shared in the query cache without worries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message