trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #760: [TRAFODION-2267] Fix ALTER TABLE RENA...
Date Wed, 12 Oct 2016 18:07:03 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/760

    [TRAFODION-2267] Fix ALTER TABLE RENAME documentation

    Problem: The SQL Reference manual describes a CASCADE keyword for ALTER TABLE RENAME,
however if you try to use it, you get error message 1427, "Table cannot be renamed. Reason:
Cascade option not supported."
    
    Supporting this option seems like a fair amount of work, so for the moment, we've simply
removed mention of CASCADE from the SQL reference manual.
    
    While working on this issue, I noticed that the DDL messages section of the Messages Guide
is woefully out-of-date. Among other things, it lacks several messages including the message
1427 mentioned above. Fixing all of that is a big job, but with this set of changes I did
a small part of it. I added documentation for messages 1420-1429.
    
    While doing this I noticed that ALTER TABLE RENAME to an invalid HBase name produced a
very ugly 8448 error (unlike CREATE TABLE and DROP TABLE which produce a nice tidy error 1422
in this case). I fixed the error reporting code in ALTER TABLE RENAME so that we now get the
nice error 1422 instead.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2267

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #760
    
----
commit 12ff1c4ef840c91374338ad8102f3d0c764364bb
Author: Dave Birdsall <dbirdsall@apache.org>
Date:   2016-10-12T17:57:57Z

    [TRAFODION-2267] Fix ALTER TABLE RENAME documentation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message