trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mkby <>
Subject [GitHub] incubator-trafodion pull request #807: [TRAFODION-1839] Trafodion Installer ...
Date Wed, 02 Nov 2016 07:40:07 GMT
Github user mkby commented on a diff in the pull request:
    --- Diff: install/python-installer/ ---
    @@ -0,0 +1,119 @@
    +#!/usr/bin/env python
    +# @@@ START COPYRIGHT @@@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +# @@@ END COPYRIGHT @@@
    +### this script should be run on all nodes with sudo user ###
    +import re
    +import os
    +import sys
    +import json
    +import platform
    +from common import run_cmd, cmd_output, err
    +# not used
    +EPEL_REPO = """
    --- End diff --
     we only need 'pdsh' dependency from epel repository, so I'm thinking to install 'pdsh'
rpm directly, but not use epel repository. Is it acceptable?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message