trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <>
Subject [GitHub] incubator-trafodion pull request #826: {TRAFODION-1562] Index maintenence pe...
Date Thu, 10 Nov 2016 02:19:28 GMT
Github user zellerh commented on a diff in the pull request:
    --- Diff: core/sql/optimizer/BindWA.h ---
    @@ -685,6 +685,8 @@ class BindScope : public NABasicObject
       // --------------------------------------------------------------------
       RelExpr *&getSequenceNode() { return sequenceNode_; };
    +  ValueIdMap &getNcToOldMap() { return ncToOldMap_;}
    --- End diff --
    For new code, could you make a "get" and a "set" method instead of returning a writable
reference. I know a lot of old code still has this style of method.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message