trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #826: {TRAFODION-1562] Index maintenence pe...
Date Thu, 10 Nov 2016 20:46:12 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/826#discussion_r87482011
  
    --- Diff: core/sql/optimizer/BindRelExpr.cpp ---
    @@ -10298,10 +10331,17 @@ RelExpr *Insert::bindNode(BindWA *bindWA)
       }
     
       if (isUpsertThatNeedsMerge(isAlignedRowFormat, omittedDefaultCols, omittedCurrentDefaultClassCols))
{
    -    boundExpr = xformUpsertToMerge(bindWA);
    -    return boundExpr;
    +    if (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_OFF) 	
    +      {
    +	boundExpr = xformUpsertToMerge(bindWA);  
    +	return boundExpr;
    +      }
    +      else if( CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON)
    +	boundExpr = xformUpsertToEfficientTree(bindWA);
    +    
    --- End diff --
    
    Yes removed the second "if" so it can default to one of the cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message