trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From svarnau <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #827: [TRAFODION-2256] installer not detect...
Date Tue, 15 Nov 2016 17:27:01 GMT
Github user svarnau commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/827#discussion_r88068198
  
    --- Diff: install/installer/traf_start ---
    @@ -58,19 +58,19 @@ else
            error1392=$(grep "1392" $SQ_ROOT/initializeErrors.txt | wc -l)
            error1395=$(grep "1395" $SQ_ROOT/initializeErrors.txt | wc -l)
            if [ "$error1395" -ge "1" ] || [ "$error1392" -ge "1" ]; then
    -          ssh $STARTING_NODE "cd $SQ_ROOT/sql/scripts;  echo \"get version of metadata;\"
| sqlci" | tee -a $SQ_ROOT/initalizeErrors.txt
    +          ssh $STARTING_NODE "cd $SQ_ROOT/sql/scripts;  echo \"get version of metadata;\"
| sqlci" | tee -a $SQ_ROOT/initializeErrors.txt
                metadataCurrent=$(grep "Metadata is current" $SQ_ROOT/initializeErrors.txt
| wc -l)
                if [[ "$metadataCurrent" -ne "1" ]]; then
                   ssh $STARTING_NODE "cd $SQ_ROOT/sql/scripts;  echo \"initialize Trafodion,
upgrade;\" | sqlci" | tee -a $SQ_ROOT/initializeErrors.txt
                fi
    -        fi
    -
    -        if [ "$?" != "0" ]; then
    -           echo "***ERROR: initialize Trafodion failed.  Check install log files for
details." | tee -a $INSTALL_LOG
    -           exit -1;
    -        fi
    +       else
    --- End diff --
    
    I totally missed seeing this comment from last week. Thanks for the review. 
    I agree and will make the suggested change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message