trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #835: [TRAFODION-2342] hdfs access threads ...
Date Wed, 16 Nov 2016 00:13:22 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/835#discussion_r88143836
  
    --- Diff: core/sql/exp/ExpLOBaccess.cpp ---
    @@ -2280,8 +2280,10 @@ Ex_Lob_Error ExLobsOper (
     	  return LOB_GLOB_PTR_ERROR;
     	}
         }
    -
    -  if ((globPtr != NULL) && (operation != Lob_Init))
    +  if (globPtr != NULL)
    +  {
    +    lobGlobals = (ExLobGlobals *)globPtr;
    +    if ((operation != Lob_Init) && (operation != Lob_Cleanup))
    --- End diff --
    
    Thanks @DaveBirdsall.  Line 2285 is needed. I will remove line 2288 when I get a chance
to submit something else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message