trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #837: [TRAFODION-2355] document about IP ad...
Date Tue, 22 Nov 2016 17:46:00 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/837#discussion_r89170789
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc
---
    @@ -3596,6 +3647,144 @@ SALES REP
     ```
     
     <<<
    +[[is_ipv4_function]]
    +== IS_IPV4 Function
    +
    +For a given argument, if it is a valid IPV4 string, IS_IPV4() returns 1 else returns
0. 
    +```
    +IS_IPV4( expression )
    +```
    +
    +* `_expression_`
    ++
    +specifies an expression that determines the values to include in the
    --- End diff --
    
    This paragraph doesn't look right to me. It looks like a discussion of an aggregate function,
which IS_IPV4 is not (as far as I know). Perhaps it should say, "specifies a string expression
to be checked" and nothing more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message