trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #876: [Trafodion 2351] Bulk load with log e...
Date Mon, 19 Dec 2016 04:17:00 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/876#discussion_r92966401
  
    --- Diff: core/sql/executor/ExHbaseAccess.cpp ---
    @@ -3050,9 +3059,9 @@ void ExHbaseAccessTcb::buildLoggingPath(
          struct tm * curgmtime = gmtime(&t);
          strftime(logId_tmp, sizeof(logId_tmp)-1, "%Y%m%d_%H%M%S", curgmtime);
          logId = logId_tmp;
    -  }
    -  sprintf(loggingFileName, "%s/ERR_%s/%s_%s_%d",
    -                  loggingLocation, logId, tableName, loggingFileNamePrefix, instId);
    +  } 
    +  sprintf(currCmdLoggingLocation, "%s/ERR_%s_%s",
    --- End diff --
    
    The loggingLocation_ is allocated in line 1889 in setLoggingLocation_ with large enough
buffer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message