trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1045: [TRAFODION-2566] Reduce the virtual ...
Date Wed, 05 Apr 2017 22:09:25 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1045#discussion_r110039725
  
    --- Diff: core/sql/udrserv/udrserv.cpp ---
    @@ -236,7 +238,27 @@ void InitializeJavaOptionsFromEnvironment(LmJavaOptions &javaOptions
        int maxHeapEnvvarMB = DEFAULT_JVM_MAX_HEAP_SIZE;
        sprintf(maxHeapOption, "-Xmx%dm", maxHeapEnvvarMB);
        javaOptions.addOption((const char *)maxHeapOption, TRUE);
    -   
    +
    --- End diff --
    
    You talked in the conversation thread about avoiding duplication of code. Selva and I
also talked about that. The Language manager has the nice feature of being able to pass JVM
options from the outside. If we allow this for JavaObjectInterface::createJVM() as well, couldn't
we then combine the code? If I ever have time to do this, I'll attempt it, but right now it
doesn't look like that will happen anytime soon.
    
    For now, this looks good to me. If you like we can file a JIRA to combine JVM startup
and to call JavaObjectInterface::createJVM() in the language manager instead of using its
own code. Note that we may call this LanguageManager code from the executor as well, although
it's probably highly unlikely right now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message