trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1036: [TRAFODION-2554]Convert into Maven p...
Date Mon, 10 Apr 2017 17:58:31 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1036#discussion_r110721219
  
    --- Diff: core/conn/jdbc_type2/src/main/java/org/apache/trafodion/jdbc/t2/SQLMXPooledConnectionManager.java
---
    @@ -23,14 +23,14 @@
      * Filename : SQLMXPooledConnectionManager.java
      */
     
    -package org.trafodion.jdbc.t2;
    +package org.apache.trafodion.jdbc.t2;
     
     import java.sql.*;
     import javax.sql.*;
     import java.util.Properties;
     import java.util.LinkedList;
     import java.io.PrintWriter;
    -import org.trafodion.jdbc.t2.*;
    +import org.apache.trafodion.jdbc.t2.*;
    --- End diff --
    
    Just a minor question: Do we really need to import the content of our own package?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message