trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1041: Rework the fix for [TRAFODION-2516] ...
Date Tue, 11 Apr 2017 23:25:43 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1041#discussion_r111035970
  
    --- Diff: core/sql/bin/clitest.cpp ---
    @@ -316,7 +317,9 @@ case 7:
     	  return retcode;
               }
             cout << "LOB handle for "<< columnname << ": " << lobHandle
<< endl;
    -	retcode = updateAppendBufferToLobHandle(cliGlob,lobHandle);
    +        char *source= new char[300];
    --- End diff --
    
    This is a test program so I suppose we don't care about the memory leak here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message