trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1068: [TRAFODION-2594] Trafodion logs the ...
Date Wed, 19 Apr 2017 00:53:57 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1068#discussion_r112096641
  
    --- Diff: core/sqf/conf/log4cxx.trafodion.masterexe.config ---
    @@ -44,15 +45,15 @@ log4j.appender.mxoAppender.layout=org.apache.log4j.PatternLayout
     log4j.appender.mxoAppender.layout.ConversionPattern=%d, %p, %c, %m%n
     
     #MXOSRVR
    +log4j.additive.mxoAppender=false 
     log4j.logger.MXOSRVR=ERROR, mxoAppender
     
     # SQL
     # uncomment the following line if you want to enable debug logging
    -#log4j.logger.SQL.EXE=DEBUG
     log4j.logger.SQL=INFO
     log4j.logger.SQL.COMP=ERROR
    -log4j.logger.SQL.EXE.Memory=INFO
    -log4j.logger.SQL.ESP=ERROR
    +log4j.logger.SQL.EXE=INFO
    +log4j.logger.SQL.ESP=INFO
    --- End diff --
    
    Ok . But we are definitely changing behaviour already. There is a generic method SQLMXLoggingArea::logExecRTInfo
that uses INFO as the level. Am guessing it could affect performance since it's used in BMO
code paths.    Not sure we wnt the user to see all these messages by default. If you do a
 quick grep on our code you can see what is being logged using this generic method. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message