trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1072: [TRAFODION-2598] Lob insert-select w...
Date Thu, 27 Apr 2017 20:52:57 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1072#discussion_r113799176
  
    --- Diff: core/sql/exp/ExpLOBaccess.cpp ---
    @@ -2454,7 +2560,55 @@ Ex_Lob_Error ExLobsOper (
           err = lobPtr->writeDataSimple(source, sourceLen, subOperation, retOperLen,
     				    bufferSize , replication , blockSize);
           break;
    +    case Lob_InsSel:
    +      {
    +        
    +        ExLob *srcLobPtr;
    +        Int16 flags;
    +        Lng32  lobNum;
    +        Int32 lobType;
    +        Int64 uid, inDescSyskey, descPartnKey;
    +        short schNameLen;
    +        char schName[1024];
    --- End diff --
    
    I see several fixed-length char arrays here. Do we have guarantees that these won't overrun?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message