trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1074: [TRAFODION-2294] Fix permissions hol...
Date Thu, 27 Apr 2017 21:43:51 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1074#discussion_r113809950
  
    --- Diff: core/sql/arkcmp/CmpStatement.cpp ---
    @@ -1072,7 +1082,8 @@ CmpStatement::process(const CmpMessageDDLwithStatus &statement)
     				 odbcProcess,
     				 noTextCache,
     				 aqrPrepare,
    -				 standaloneQuery))
    +				 standaloneQuery,
    +				 doNotCachePlan))
    --- End diff --
    
    Yes. In the separate compiler case, the CmpCompileInfo object is sent to the tdm_arkcmp
process. In the embedded case, it is passed to CmpContext::compileDirect. Either way, the
bit travels to CmpStatement::process and ultimately down to CmpMain::sqlcomp. I've unit tested
both paths.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message