trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1057: [TRAFODION-2569] Improve handling of...
Date Mon, 10 Apr 2017 17:48:31 GMT
GitHub user zellerh opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1057

    [TRAFODION-2569] Improve handling of index hints

    Allowing hints in update and delete statements - they apply to the
    scan of the table. Also making sure that heuristics to eliminate
    indexes don't apply to indexes listed in a hint. Excluding the right
    child of an index join when giving priority to plans that satisfy the
    hint. Otherwise, an index join (index - base table) could be chosen
    when the hint lists the base table.
    
    Also removed some unused interfaces:
    - no_log option in grammar, since it made changing the update syntax harder.
      If we decide to implement incremental MVs in the future, we should use
      a better parser or a different syntax for the no log feature.
    - Some obsolete parser rules.
    - Another set of hints in the scan node, in addition to those in the RelExpr.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zellerh/incubator-trafodion bug/cses_jan-17

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1057
    
----
commit 7cb964f52202f2283d0dd34975e28af179e785a2
Author: Hans Zeller <hzeller@apache.org>
Date:   2017-04-10T17:43:59Z

    [TRAFODION-2569] Improve handling of index hints
    
    Allowing hints in update and delete statements - they apply to the
    scan of the table. Also making sure that heuristics to eliminate
    indexes don't apply to indexes listed in a hint. Excluding the right
    child of an index join when giving priority to plans that satisfy the
    hint. Otherwise, an index join (index - base table) could be chosen
    when the hint lists the base table.
    
    Also removed some unused interfaces:
    - no_log option in grammar, since it made changing the update syntax harder.
      If we decide to implement incremental MVs in the future, we should use
      a better parser or a different syntax for the no log feature.
    - Some obsolete parser rules.
    - Another set of hints in the scan node, in addition to those in the RelExpr.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message