trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From svarnau <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1077: Trafodion 2001
Date Mon, 08 May 2017 20:54:36 GMT
Github user svarnau commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1077#discussion_r115350803
  
    --- Diff: install/python-installer/scripts/traf_sqconfig.py ---
    @@ -51,18 +52,15 @@ def run():
                 lines.append(line)
     
         lines.append('end node\n')
    -    lines.append('\n')
    -    lines.append('begin overflow\n')
    -
    -    for scratch_loc in scratch_locs:
    -        line = 'hdd %s\n' % scratch_loc
    -        lines.append(line)
    -
    -    lines.append('end overflow\n')
     
    +    # write out the node section
         with open(sqconfig_file, 'w') as f:
             f.writelines(lines)
     
    +    # append the current persist section to the Trafodion configuration file
    +    run_cmd('echo "sed \'1,20d\' %s >> %s"' % (sqconfig_persist_file, sqconfig_file))
    +    run_cmd('sed \'1,20d\' %s >> %s' % (sqconfig_persist_file, sqconfig_file))
    --- End diff --
    
    In fact, why are the installers concatenating these files?
    Why doesn't monitor just directly read both sqconfig and sqconfig.persist?
    Or sqgen take some file name parameters?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message