trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <>
Subject [GitHub] incubator-trafodion pull request #1087: [TRAFODION-2420] RMS enhancements
Date Tue, 09 May 2017 21:02:44 GMT
Github user zellerh commented on a diff in the pull request:
    --- Diff: core/sql/executor/ex_hash_grby.cpp ---
    @@ -452,6 +463,8 @@ short ex_hash_grby_tcb::work() {
                 hasFreeTupp_ = TRUE;
    +      if (bmoStats_)
    +         bmoStats_->setBmoPhase(PHASE_END-HGB_READ_PHASE);
    --- End diff --
    This is executed for every row. Would it be cheaper to do this in the two places where
we set state_ to HASH_GRBY_READ_CHILD?
    Another question not about correctness but more related to personal taste: Why not simply
assign values 1, 2, 3 etc. in the enum instead of subtracting two enums here? Feel free to
ignore if you like this solution better.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message