trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1087: [TRAFODION-2420] RMS enhancements
Date Tue, 09 May 2017 21:43:25 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1087#discussion_r115610081
  
    --- Diff: core/sql/executor/ex_hash_grby.cpp ---
    @@ -452,6 +463,8 @@ short ex_hash_grby_tcb::work() {
                 hasFreeTupp_ = TRUE;
         	};
           };
    +      if (bmoStats_)
    +         bmoStats_->setBmoPhase(PHASE_END-HGB_READ_PHASE);
    --- End diff --
    
    For your latter question, I didn't want to disturb the existing enum values and hence
kept the existing value. But, for BMO stats, I wanted show the phase of the instance that
hasn't moved to the next higher phase.  When the BMO stats is merged from different esp instances,
 higher phase value is used. Hence, the phase enum value is reversed for BMO stats


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message