trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xwq <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1098: TRAFODION-2385 jdbcT4 support boolea...
Date Tue, 23 May 2017 10:25:40 GMT
Github user xwq commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1098#discussion_r117954467
  
    --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/InterfaceStatement.java
---
    @@ -671,6 +683,11 @@ void convertObjectToSQL2(Locale locale, TrafT4Statement pstmt, Object
paramValue
     			byte[] b = InterfaceUtilities.convertBigDecimalToSQLBigNum(tmpbd, maxLength, scale);
     			System.arraycopy(b, 0, values, noNullValue, maxLength);
     			break;
    +		case InterfaceResultSet.SQLTYPECODE_BOOLEAN:
    +			tmpbd = Utility.getBigDecimalValue(locale, paramValue);
    +
    +			Bytes.insertShort(values, noNullValue, tmpbd.shortValue(), this.ic_.getByteSwap());
    --- End diff --
    
    Why we need 2 bytes for BOOLEAN, do you compare the maxlength_ with it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message